Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wired up basic settings in AdminX portal settings #17191

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

binary-koan
Copy link
Contributor

@binary-koan binary-koan self-assigned this Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (de4186a) 71.72% compared to head (645ede7) 71.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17191      +/-   ##
==========================================
+ Coverage   71.72%   71.75%   +0.02%     
==========================================
  Files        1836     1836              
  Lines      116454   116454              
  Branches    17287    17292       +5     
==========================================
+ Hits        83532    83566      +34     
+ Misses      31803    31767      -36     
- Partials     1119     1121       +2     
Flag Coverage Δ
e2e-tests 66.48% <ø> (-0.04%) ⬇️
unit-tests 63.70% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binary-koan binary-koan merged commit 7f9f467 into main Jul 4, 2023
@binary-koan binary-koan deleted the adminx-portal-basic-settings branch July 4, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant