Ensure hidden settings return falsy when used with the @custom helper
#17920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #17920 +/- ##
==========================================
- Coverage 66.79% 66.79% -0.01%
==========================================
Files 1470 1470
Lines 83096 83099 +3
Branches 11201 11203 +2
==========================================
+ Hits 55503 55504 +1
- Misses 26459 26462 +3
+ Partials 1134 1133 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mike182uk
force-pushed
the
theme-settings-dependency-custom-helper
branch
7 times, most recently
from
08b7055
to
1d6da63
Compare
no refs When a theme setting is hidden, it should return a falsy value when used
mike182uk
force-pushed
the
theme-settings-dependency-custom-helper
branch
from
1d6da63
to
f67321d
Compare
mike182uk
added a commit
to mike182uk/Ghost
that referenced
this pull request
Sep 26, 2023
refs TryGhost/Product#3962 Port custom theme setting visibility to admin-x based on previous implementation in the Ghost admin: TryGhost#17920
mike182uk
added a commit
to mike182uk/Ghost
that referenced
this pull request
Sep 26, 2023
refs TryGhost/Product#3962 Port custom theme setting visibility to admin-x based on previous implementation in the Ghost admin: TryGhost#17920
mike182uk
added a commit
to mike182uk/Ghost
that referenced
this pull request
Sep 26, 2023
refs TryGhost/Product#3962 Port custom theme setting visibility to admin-x based on previous implementation in the Ghost admin: TryGhost#17920
mike182uk
added a commit
to mike182uk/Ghost
that referenced
this pull request
Sep 26, 2023
refs TryGhost/Product#3962 Port custom theme setting visibility to admin-x based on previous implementation in the Ghost admin: TryGhost#17920
mike182uk
added a commit
to mike182uk/Ghost
that referenced
this pull request
Sep 26, 2023
refs TryGhost/Product#3962 Port custom theme setting visibility to admin-x based on previous implementation in the Ghost admin: TryGhost#17920
mike182uk
added a commit
to mike182uk/Ghost
that referenced
this pull request
Sep 28, 2023
refs TryGhost/Product#3962 Port custom theme setting visibility to admin-x based on previous implementation in the Ghost admin: TryGhost#17920
mike182uk
added a commit
to mike182uk/Ghost
that referenced
this pull request
Sep 28, 2023
refs TryGhost/Product#3962 Port custom theme setting visibility to admin-x based on previous implementation in the Ghost admin: TryGhost#17920
mike182uk
added a commit
to mike182uk/Ghost
that referenced
this pull request
Oct 2, 2023
refs TryGhost/Product#3962 Port custom theme setting visibility to admin-x based on previous implementation in the Ghost admin: TryGhost#17920
mike182uk
added a commit
that referenced
this pull request
Oct 2, 2023
refs TryGhost/Product#3962 Port custom theme setting visibility to admin-x based on previous implementation in the Ghost admin: #17920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no refs
When a theme setting is hidden, it should return a falsy value when used