Added knex repositories #20239
Closed
Added knex repositories #20239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs https://linear.app/tryghost/issue/MOM-122 The data in ActivityPub is all different shapes - so we are using a JSON column to store it. We've moved a few key pieces of data to their own columns to make searching easier.
DES-351 There's a frontend validation in Settings that rewrites the Twitter (X) URL in social accounts to match the format: twitter.com. As of May 17, X officially changed their domain to x.com so this validation is outdated. --------- Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
DES-355 There's been an orphan in the schedule toast notification and the date format was non-standard.
DES-194 The tooltip of scheduled posts always showed subscribers even if it was not sent as a newsletter.
DES-342 A static site title ("The Local Host") was displayed in the newsletter preview instead of the actual site title. Also, moved over the "Support independent publishing" button to design tab in newsletter settings.
ref MOM-123 This is 100% a WIP and not ready yet. Many questions need to be answered first before proceeding
ref MOM-123
ref MOM-123 - Added a create factory to the `activity` entity, so we can return a new `Activity` entity when fetching the data from the db
ref MOM-123 Instead of create a knex timestamp, we take the one that exists on the entity already. For this, I added a new date validation to the `create` factories, which ensures that the entities always have the correct timestamp
aileen
force-pushed
the
activitypub-aileen
branch
from
e4f412b
to
15a8ff4
Compare
ref MOM-123 - Hook up the knex repositories to be used instead of the in-memory ones
aileen
force-pushed
the
activitypub-aileen
branch
2 times, most recently
from
a46ae95
to
7bbe364
Compare
With the labs flags enabled by default in our e2e tests, some tests where triggering the ActivityPub services (e.g. post publishing). I added a mock util for now to stub out the requests. In the future, we should add the data fixtures to the tests and include ActivityPub in the e2e test.
aileen
force-pushed
the
activitypub-aileen
branch
from
7bbe364
to
3c696df
Compare
MOM-123 Added update functionality when an activity already exists. Added a `getJSON` method to `activity` and `actor` entity, as well as `Article` object, to ensure we only store in the DB what we need to (no events, or other entity properties) I'm still not entirely sure about the ID's. I added a small helper function to help exctract the ID from the URL, because creating an ObjectID from the whole URL doesn't work, as it's too long.
aileen
force-pushed
the
activitypub-aileen
branch
from
d7d277c
to
306b1d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref MOM-123
actorsandactivitiesto store values in the DB