🐛 Fixed button URL suggestions not loading for contributors, editors and authors #20416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagzy
changed the title
sagzy
force-pushed
the
fix/SLO-127
branch
2 times, most recently
from
3fb8b02
to
4bd609d
Compare
ref https://linear.app/tryghost/issue/SLO-127 - if offers fail to fetch for some reason (e.g. permission), the rest of the url suggestions for cards with a button (Button, Product, Email CTA) should still work - as an example use case, contributors do not have access to browse offers. They currently don't see any button url suggestions, not even the default links to the homepage or free signup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/tryghost/issue/SLO-127