Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt task to look for vulnerabilities in dependencies added #4787

Closed
wants to merge 2 commits into from
Closed

Grunt task to look for vulnerabilities in dependencies added #4787

wants to merge 2 commits into from

Conversation

jesusprubio
Copy link

To look for dependencies with known vulnerabilities. Now we still have one related with the project "htmlparser2", but the issue is still opened: fb55/htmlparser2#105

retireghost

@ErisDS
Copy link
Member

ErisDS commented Jan 10, 2015

@jesusprubio Hi there, thanks for the PR :) Just FYI, there's no need to close / reopen PRs, you can always update an open one. I recommend checking out our contribution guidelines as that will give you lots of info on how to fixup PRs, including how to squash commits down and links to our code style etc.

It's also worth taking a look at this PR: #4292 and its related issue as this was attempted before (adding a retire grunt task) and it didn't work out. Perhaps the issues are now resolved, but it's worth a look.

@jesusprubio
Copy link
Author

Sorry, my fault, I'm closing it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants