🐛 re-order api middlewares: cors middleware before connect-slashes #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kirrg001 LGTM 👍 One really annoying linter error though 😞 |
😖 will fix asap |
closes TryGhost#7839 - when a browser sends a request to the API without a trialing slash, we are using connect-slashes to redirect permanently - but because the CORS middleware was registered after the redirect, the CORS headers got lost
kirrg001
force-pushed
the
fix/api-middleware-order
branch
from
4bd17a9
to
fe2653f
Compare
|
Green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7839
Reproduced and tested the fix via browser.