🎨 Use settingsCache in theme handler #8091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the settingsCache here, makes no sense to call the API
kirrg001
approved these changes
Mar 2, 2017
👍 you can push the TODO directly to master if you want - and we could agree on: if we see a usage, we will change it |
|
Yeah sounds sane. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have the settingsCache here, makes no sense to call the API
There are definitely other places that we can do this - I'm doing this one as it impacts on the theme code I'm working on.
Might be an idea to add a TODO somewhere to revisit usages of
settings.read?