🔥 Remove handlebars from serving admin #8184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErisDS
force-pushed
the
remove-admin-hbs
branch
2 times, most recently
from
c6c1be8
to
d56cf55
Compare
refs TryGhost#8140 refs TryGhost/Admin#593 - now that the admin index page is just html, we don't need handlebars anymore - as we can use res.sendFile to send the static HTML file, don't need to "render" it anymore - remove the view engine, hbs and the use of helpers - it's all unneeded - change the filenames to .html to reflect this
ErisDS
force-pushed
the
remove-admin-hbs
branch
from
d56cf55
to
82fcc88
Compare
kevinansfield
pushed a commit
to TryGhost/Admin
that referenced
this pull request
Mar 20, 2017
refs TryGhost/Ghost#8140 refs TryGhost/Ghost#8184 - now that the admin index page is just html, we don't need handlebars anymore - this changes the template be called .html to reflect this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires TryGhost/Admin#593
refs #8140