👋🏼 Don't use ghosticon.jpg from admin assets #8285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aileen
added a commit
to aileen/Admin
that referenced
this pull request
Apr 6, 2017
refs TryGhost/Ghost#8221 needs TryGhost/Ghost#8285 Remove `ghosticon.jpg` as it's not used anymore.
aileen
force-pushed
the
go-away-ghosticon
branch
from
514b7c1
to
5c08fe2
Compare
|
This should be ready for review and merging 🎉 |
refs TryGhost#8221 Use our default `favicon.ico` instead of `ghosticon.jpg` which is served from the admins' assets. Adds additionally fake image dimensions for our json-ld data to satisfy Google.
aileen
force-pushed
the
go-away-ghosticon
branch
from
5c08fe2
to
9f296cc
Compare
kevinansfield
pushed a commit
to TryGhost/Admin
that referenced
this pull request
Apr 7, 2017
refs TryGhost/Ghost#8221 needs TryGhost/Ghost#8285 Remove `ghosticon.jpg` as it's not used anymore.
aileen
added a commit
to aileen/Ghost
that referenced
this pull request
Apr 11, 2017
refs TryGhost#8221 This is a follow-up PR for TryGhost#8285. Reasons: The code changes of TryGhost#8285 caused error messages when falling back to the default `favicon.ico`, as the `image-size` tool doesn't support `ico` files. This PR takes the logic to decide which logo needs to be listed in our schema into a new fn `blog_logo.js`. There we have now three decisions: 1. If we have a publication **logo**, we'll take that one 2. If we have no publication logo, but an **icon** we'll use this one. 3. If we have none of the above things, we fall back to our default `favicon.ico` Additional, we're hard coding image dimensions for whenever the logo is an `.ico` file and built and extra decision to not call `image-size` when the dimension are already given. I will create another follow-up PR, which checks the extension type for the file and offers it as a util.
kirrg001
pushed a commit
that referenced
this pull request
Apr 11, 2017
refs #8221, closes #7688, refs #7558 🙇 Improve meta data publisher logo behaviour This is a follow-up PR for #8285. Reasons: The code changes of #8285 caused error messages when falling back to the default `favicon.ico`, as the `image-size` tool doesn't support `ico` files. This PR takes the logic to decide which logo needs to be listed in our schema into a new fn `blog_logo.js`. There we have now three decisions: 1. If we have a publication **logo**, we'll take that one 2. If we have no publication logo, but an **icon** we'll use this one. 3. If we have none of the above things, we fall back to our default `favicon.ico` Additional, we're hard coding image dimensions for whenever the logo is an `.ico` file and built and extra decision to not call `image-size` when the dimension are already given. I will create another follow-up PR, which checks the extension type for the file and offers it as a util. 🛠 Blog icon util refs #7688 Serve functionality around the blog icon in its own util: - getIconDimensions -> async function that takes the filepath of on ico file and returns its dimensions - isIcoImageType -> returns true if file has `.ico` extension - getIconType -> returns icon-type (`x-icon` or `png`) - getIconUrl -> returns the absolut or relativ URL for the favicon: `[subdirectory or not]favicon.[ico or png]` 📖 Get .ico sizes for meta data & logo improvement refs #7558 refs #8221 Use the new `blogIconUtil` in meta data to fetch the dimensions of `.ico` files. Improvements for `publisher.logo`: We're now returning a hard-coded 'faked' image dimensions value to render an `imageObject` and prevent error our schema (Google structured data). As soon as an image (`.ico` or non-`.ico`) is too large, but - in case of non-`.ico` - a square format, be set the image-dimensions to 60px width and height. This reduces the chances of getting constantly error messages from Googles' webmaster tools. - add getIconPath util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8221
Use our default
favicon.icoinstead ofghosticon.jpgwhich is served from the admins' assets.Adds additionally fake image dimensions for our json-ld data to satisfy Google.