Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using yarn instead of npm according to the paragraph above it #8288

Closed
wants to merge 1 commit into from
Closed

Using yarn instead of npm according to the paragraph above it #8288

wants to merge 1 commit into from

Conversation

felixsanz
Copy link

@felixsanz felixsanz commented Apr 6, 2017

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • Commit message has a short title & issue references
  • Commits are squashed
  • The build will pass (run npm test).

More info can be found by clicking the "guidelines for contributing" link above.

@kevinansfield
Copy link
Member

kevinansfield commented Apr 6, 2017

@felixsanz thanks for taking the time to check the docs 😄 npm run and yarn run will do (mostly? we haven't tested so didn't want to update yet) the same thing. I had intentionally left it as npm run so that we're using the same script runner as our non-developer docs, we're only using yarn for dependency management right now.

@kirrg001
Copy link
Contributor

Hmmm from my perspective it would be correct to accept this change, because the init command is already using yarn. And as @kevinansfield said, they are doing the same. I think it's less confusing if we switch to yarn run init.

@kevinansfield
Copy link
Member

👍 fine with me if everything works

@kirrg001
Copy link
Contributor

@felixsanz Could you please rebase? Thank you!

@kirrg001 kirrg001 self-assigned this May 15, 2017
@kirrg001
Copy link
Contributor

@felixsanz ping

@kirrg001
Copy link
Contributor

Closing in favour of #8475, thanks again 👋

@kirrg001 kirrg001 closed this May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants