🙀 Image field naming & new img_url helper #8364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
1.0.0-dev/image-refactoring
branch
2 times, most recently
from
bbb2421
to
dc5da7a
Compare
kirrg001
changed the title
aileen
approved these changes
Apr 24, 2017
- rename user/post/tag images - contains all the required changes from the schema change
- rename cover to cover_image - also rename default settings to match the pattern - rename image to profile_image for user - rename image to feature_image for tags/posts
- rename
- change the functionality
- attr is required
- e.g. {{img_url feature_image}}
- update yarn.lock
kirrg001
force-pushed
the
1.0.0-dev/image-refactoring
branch
from
70decfc
to
a3718bc
Compare
kevinansfield
pushed a commit
to TryGhost/Admin
that referenced
this pull request
Apr 24, 2017
refs TryGhost/Ghost#8348, requires TryGhost/Ghost#8364 - rename all image properties - e.g. author.image --> author.profile_image - test all image functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8348
I have to finish all sub tasks in one PR, because they are related. Each sub tasks get's a commit.
e.g. if i change the schema, the meta helper won't work anymore.
You can use the new
img_urlhelper everywhere.If the target url path is null, nothing happens - the helper just returns.
If the target url is undefined e.g.
{{img_url}}-> an error is thrown.TODO list