⚡️ Throw clear error message when config.url has no protocol
#8466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#8449 Fixes an issue where Ghost would crash when the URL in `config` is set up without a protocol. This PR checks the URL on startup within config utils and outputs a warning for the user, but also sanitises the URL to prevent crashes.
aileen
force-pushed
the
sanitise-urls-without-protocol
branch
from
b111720
to
7f1eb17
Compare
kirrg001
reviewed
May 18, 2017
core/server/config/utils.js
Outdated
| } else { | ||
| this.set('url', 'http://' + url); | ||
| console.log(chalk.red('Watch out! Your URL in the config should have a protocol! E.g. "http://my-ghost-blog.com"')); | ||
| console.log(chalk.white('Current URL: ') + chalk.cyan(url)); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aileen
changed the title
config.url has no protocol
closes TryGhost#8449 Preventing Ghost from starting, if `config.url` is set up without protocol, eg. `localhost:2368` instead of `http://localhost:2368` and throwing a more clear error message.
aileen
force-pushed
the
sanitise-urls-without-protocol
branch
from
0492337
to
5f9d918
Compare
kirrg001
approved these changes
May 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8449
Fixes an issue where Ghost would crash when the URL in
configis set up without a protocol.This PR checks the URL on startup within config utils and outputs a warning for the user, but also sanitises the URL to prevent crashes.
Not sure, if this is the wanted behaviour in this case. We could also prevent Ghost from starting and output a more clear error message instead... Let me know, what you'd prefer @kirrg001