Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 more config updates #8491

Merged
merged 2 commits into from
May 31, 2017
Merged

🎨 more config updates #8491

merged 2 commits into from
May 31, 2017

Conversation

kirrg001
Copy link
Contributor

refs #7488

  • simply rename internalApps -> apps.internal
  • add cache control configurations into the default config

maxAge is not that easy to read, because it's just a number without a specific period (e.g. maxAgeInMS). But yeah i don't want to spend more time on optimising that 🙈

@kirrg001
🎨 internalApps -> apps.internal
ee5aac0 
refs TryGhost#7488

- simply rename the config usage
- we might want to add `apps.external` later
@kirrg001
🎨 add cache control configurations into the default config
f0fbc07 
refs TryGhost#7488

- cache control can be overridden if needed
@kirrg001 kirrg001 assigned cobbspur and kevinansfield and unassigned cobbspur May 29, 2017
@kevinansfield kevinansfield merged commit 78ac63d into TryGhost:master May 31, 2017
@kevinansfield kevinansfield deleted the 1.0.0-dev/more-config-updates branch May 31, 2017 15:12
@kirrg001 kirrg001 mentioned this pull request May 31, 2017
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kevinansfield kevinansfield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirrg001 @kevinansfield @cobbspur