Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 show clearer error for wrong content path #8535

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Jun 6, 2017

no issue

@kirrg001 kirrg001 force-pushed the 1.0.0-dev/errror-for-content-path branch from f17abe2 to 5f91eba Compare June 6, 2017 20:32
@kirrg001
Copy link
Contributor Author

kirrg001 commented Jun 6, 2017

@AileenCGN Please see TODO in the commit.

Could you please add this to the documentation on docs.ghost.org [configuration#paths]?
Plus raise a little issue in Ghost Ignition? We have to extend Ghost Ignition to be a little bit more flexible if the logs folder doesn't exist and probably print a warning.

@kirrg001 kirrg001 force-pushed the 1.0.0-dev/errror-for-content-path branch from 9a8be34 to 239fe13 Compare June 7, 2017 08:29
@aileen
Copy link
Member

aileen commented Jun 7, 2017

@kirrg001 docs are updated and I raised an issue on Ignition to add a new error/warning for this case: TryGhost/Ignition#39

@aileen
Copy link
Member

aileen commented Jun 7, 2017

LGTM! Tested with missing default content/ directory as well as wrong config.contentPath 🎉

@aileen aileen merged commit d6d3438 into TryGhost:master Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants