🐛 Honour labs defaults on import #8667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
reviewed
Jul 9, 2017
| @@ -54,6 +58,12 @@ class SettingsImporter extends BaseImporter { | |||
|
|
|||
| _.each(this.dataToImport, function (obj) { | |||
| obj.key = self.legacySettingsKeyValues[obj.key] || obj.key; | |||
|
|
|||
| if (obj.key === 'labs' && labsSetting && labsSetting.value) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
closes TryGhost#8601 - This makes sure that when you do an import, you still get the LATEST default settings for labs. Even if you had a different value before. - LTS -> 1.0 is an upgrade, and Public API should be on by default, even if you had deliberately turned it off before. - Cheeky test added
kirrg001
approved these changes
Jul 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8601
default settings for labs. Even if you had a different value before.
had deliberately turned it off before.