Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 respect owner user id references when importing #8693

Merged
merged 2 commits into from
Jul 20, 2017

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Jul 14, 2017

closes #8691

There was a condition added when i've refactored the importer.

if (models.User.isOwnerUser(obj[key])) {

This condition is absolutely wrong! If you import an owner user, this owner user get's imported as administrator. But the original owner user id reference must be updated as well, so that the reference points to the new administrator id ✌🏻

I've tested the Bob/Rachel use case, works for me now.

@kirrg001 kirrg001 added the P2 - High [triage] High priority for immediate patch release label Jul 14, 2017
@kirrg001 kirrg001 mentioned this pull request Jul 19, 2017
@kirrg001 kirrg001 assigned kevinansfield and aileen and unassigned ErisDS Jul 20, 2017
@kirrg001
Copy link
Contributor Author

@AileenCGN @kevinansfield I've assigned you both for testing.

@aileen
Copy link
Member

aileen commented Jul 20, 2017

Tested the various described situation (first status quo, then with the PR) and it works fine for me!

@kevinansfield
Copy link
Member

👍 Also confirmed working

@kevinansfield kevinansfield merged commit 90fc7a6 into TryGhost:master Jul 20, 2017
@kevinansfield kevinansfield deleted the 1.0.0-dev/fix-id-references branch July 20, 2017 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 - High [triage] High priority for immediate patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importer does not keep correct authors
4 participants