Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Private RSS feed #9088

Merged
merged 10 commits into from
Oct 5, 2017
Merged

✨ Private RSS feed #9088

merged 10 commits into from
Oct 5, 2017

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Oct 3, 2017

refs #9001

  • reconsider core settings vs private setting - where should the hash live?
  • add admin ui change - show the direct link for the private rss feed
  • test on subdir
  • describe how this feature works
  • add more tests
  • code quality check

what can you expect

  • if your blog is public, rss still works as before
  • if your blog is private, the default rss feature is disabled
  • if your blog is private, you have access to a private rss feed from outside
  • this private rss feed url is displayed in the admin UI
  • you can access all rss urls e.g. /:hash/rss, /:hash/rss/2, /tag/:slug/:hash/rss
  • sitemaps weren't touched at all here

Note: I had several implementation options. e.g. we could register a whole new route for the hashed url, but that is super complicated e.g. we need to outsource rss into an app/module and the hash can change. And i really like url rewriting for this case.

@kevinansfield
Copy link
Member

@kirrg001 do you have an idea how the private RSS hash can be exposed to the client? Right now the core settings aren't accessible so it's not possible for the client to use hash to show the private RSS url.

@kirrg001
Copy link
Contributor Author

kirrg001 commented Oct 4, 2017

@kevinansfield Yeah is on my list 👍

reconsider core settings vs private setting - where should the hash live?

@kirrg001 kirrg001 changed the title [WIP] Private RSS feed ✨ Private RSS feed Oct 5, 2017
@kirrg001
Copy link
Contributor Author

kirrg001 commented Oct 5, 2017

Ready for review!

@kevinansfield kevinansfield merged commit 7800ed3 into TryGhost:master Oct 5, 2017
@kevinansfield kevinansfield deleted the private-rss branch October 5, 2017 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants