Moved mobiledoc/markdown converters to apps/default-cards #9338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#9178 - they definitely don't belong to server/utils - i think the best place is putting them into the card apps - the the post model needs to ask the app for it's converters - move tests as well
kirrg001
force-pushed
the
move-converters
branch
from
5de8388
to
172665a
Compare
|
@kirrg001 do we want to merge this as part of the current cleanup then refactor into |
|
Ah okay, we want to get rid of the whole app, yeah let's do that - i was wondering a couple of times in the past anyway why it's an app. I would still merge it, because we have to move these converters anyway and then move the whole folder to |
kirrg001
added a commit
to kirrg001/Ghost
that referenced
this pull request
Dec 14, 2017
kevinansfield
pushed a commit
that referenced
this pull request
Dec 14, 2017
kevinansfield
pushed a commit
to kevinansfield/Koenig
that referenced
this pull request
Mar 20, 2020
refs #9178, refs TryGhost/Ghost#9338
kevinansfield
pushed a commit
to TryGhost/Koenig
that referenced
this pull request
Apr 8, 2020
refs #9178, refs TryGhost/Ghost#9338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9178
@kevinansfield Assigning you to share this knowledge. We are currently killing our big utils folder and put the files into new places. I think the best place is inside the app. I've tested with the client, looks like everything is still working 👍