This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Created member with name on checkout completion #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost/Ghost#12270 Previously we would create the member, and then update their name from stripe data, this mean that webhooks would be sent _without_ a name, despite us possibly having the information to provide one. Here we've updated the creation of members to include the name attached to the default billing method, this will ensure that webhooks are sent with all availiable information.
allouis
added a commit
to allouis/Ghost
that referenced
this pull request
Oct 19, 2020
closes TryGhost#12270 refs TryGhost/Members#209 This includes a change to member creation after a Stripe Checkout, we now add the name from the default payment method at creation, rather than updating it after.
allouis
added a commit
to TryGhost/Ghost
that referenced
this pull request
Oct 19, 2020
closes #12270 refs TryGhost/Members#209 This includes a change to member creation after a Stripe Checkout, we now add the name from the default payment method at creation, rather than updating it after.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TryGhost/Ghost#12270
Previously we would create the member, and then update their name from
stripe data, this mean that webhooks would be sent without a name,
despite us possibly having the information to provide one.
Here we've updated the creation of members to include the name attached
to the default billing method, this will ensure that webhooks are sent
with all availiable information.