Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member name not available in webhook after creation #12270

Closed
daniellockyer opened this issue Oct 12, 2020 · 0 comments · Fixed by #12292
Closed

Member name not available in webhook after creation #12270

daniellockyer opened this issue Oct 12, 2020 · 0 comments · Fixed by #12292
Assignees
@allouis
Labels
bug [triage] something behaving unexpectedly

Comments

@daniellockyer
Copy link
Member

daniellockyer commented Oct 12, 2020 •
edited
Loading

Issue Summary

Our "Member Created" Zap listens to the member.created webhook for the creation of a member. If a member is created after subscribing via Stripe, the corresponding member.created payload doesn't contain their name. It is updated in a subsequent request.

The workaround is to listen to the member.edited webhook, which should be triggered just after with the name.

To Reproduce

  1. Listen to the member.created webhook (using the Member Created step in Zapier to make it easier)
  2. Create a paid member by signing up and filling Stripe out
  3. See that the member's name is not passed in the payload

Technical details:

  • Ghost Version: 3.35.5
  • Node Version: 12.13.0
  • Browser/OS: -/-
  • Database: MySQL
@naz naz added bug [triage] something behaving unexpectedly members labels Oct 12, 2020
@naz naz mentioned this issue Oct 12, 2020
Closed
11 tasks
allouis added a commit to allouis/Members that referenced this issue Oct 19, 2020
@allouis
Created member with name on checkout completion
67794f7 
refs TryGhost/Ghost#12270

Previously we would create the member, and then update their name from
stripe data, this mean that webhooks would be sent _without_ a name,
despite us possibly having the information to provide one.

Here we've updated the creation of members to include the name attached
to the default billing method, this will ensure that webhooks are sent
with all availiable information.
@allouis allouis mentioned this issue Oct 19, 2020
Merged
allouis added a commit to TryGhost/Members that referenced this issue Oct 19, 2020
@allouis
Created member with name on checkout completion (#209)
eb76539 
refs TryGhost/Ghost#12270

Previously we would create the member, and then update their name from
stripe data, this mean that webhooks would be sent _without_ a name,
despite us possibly having the information to provide one.

Here we've updated the creation of members to include the name attached
to the default billing method, this will ensure that webhooks are sent
with all availiable information.
allouis added a commit to allouis/Ghost that referenced this issue Oct 19, 2020
@allouis
Updated @tryghost/members-api to 0.33.3
07bff53 
closes TryGhost#12270
refs TryGhost/Members#209

This includes a change to member creation after a Stripe Checkout, we
now add the name from the default payment method at creation, rather
than updating it after.
@allouis allouis mentioned this issue Oct 19, 2020
Merged
allouis added a commit that referenced this issue Oct 19, 2020
@allouis
Updated @tryghost/members-api to 0.33.3 (#12292)
7097cfe 
closes #12270
refs TryGhost/Members#209

This includes a change to member creation after a Stripe Checkout, we
now add the name from the default payment method at creation, rather
than updating it after.
daniellockyer pushed a commit that referenced this issue Jul 20, 2022
@allouis
Created member with name on checkout completion (#209)
aa228e9 
refs #12270

Previously we would create the member, and then update their name from
stripe data, this mean that webhooks would be sent _without_ a name,
despite us possibly having the information to provide one.

Here we've updated the creation of members to include the name attached
to the default billing method, this will ensure that webhooks are sent
with all availiable information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allouis allouis

Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated @tryghost/members-api to 0.33.3 allouis/Ghost
3 participants
@naz @daniellockyer @allouis