Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nyc to track test coverage #115

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Use nyc to track test coverage #115

merged 1 commit into from
Aug 22, 2020

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Jul 8, 2020

@brettz9
Copy link
Contributor Author

brettz9 commented Jul 23, 2020

This is now also rebased.

@brettz9
Copy link
Contributor Author

brettz9 commented Jul 23, 2020

I've rebased, but note there is a breaking change to avoid Node 6 since the latest nyc doens't support it, as well as other updates I'd like to make (I'd like to also drop Node 8 in a subsequent PR, but nyc still supports Node 8.9+, so keeping here for now.)

Also dropping ESLint 2 (since dropping Node 6).

@brettz9
Copy link
Contributor Author

brettz9 commented Aug 12, 2020

Sorry, hadn't noticed there were conflicts. Could you take a look at this and my other PR now? Would like to be able to check this off... :-)

@Turbo87
Copy link
Owner

Turbo87 commented Aug 21, 2020

as I mentioned before: the breaking change that is hidden in this PR should be its own dedicated PR

@brettz9
Copy link
Contributor Author

brettz9 commented Aug 22, 2020

This is now rebased (and with no additional breaking changes beyond your master commits). Plan to rebase the other PR on top of this shortly.

@Turbo87 Turbo87 changed the title Nyc Use nyc to track test coverage Aug 22, 2020
@Turbo87 Turbo87 merged commit ea4fc6b into Turbo87:master Aug 22, 2020
@brettz9 brettz9 deleted the nyc branch August 22, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants