Skip to content

Conversation

FredericWantiez
Copy link
Member

@coveralls
Copy link

coveralls commented May 31, 2021

Pull Request Test Coverage Report for Build 893419013

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 83 (14.46%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 55.435%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/container.jl 8 9 88.89%
src/contrib/AdvancedSMCExtensions.jl 0 70 0.0%
Totals Coverage Status
Change from base Build 839302048: -0.8%
Covered Lines: 204
Relevant Lines: 368

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #28 (93fa6f4) into master (1f7251e) will decrease coverage by 0.76%.
The diff coverage is 14.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   56.19%   55.43%   -0.77%     
==========================================
  Files           5        5              
  Lines         363      368       +5     
==========================================
  Hits          204      204              
- Misses        159      164       +5     
Impacted Files Coverage Δ
src/contrib/AdvancedSMCExtensions.jl 0.00% <0.00%> (ø)
src/container.jl 91.80% <88.88%> (ø)
src/resampling.jl 96.55% <100.00%> (ø)
src/smc.jl 97.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7251e...93fa6f4. Read the comment docs.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had a minor suggestion.

@yebai yebai merged commit 176640e into TuringLang:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants