Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - CompatHelper: bump compat for MCMCChains to 6 for package test, (keep existing compat) #467

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 1, 2023

This pull request changes the compat entry for the MCMCChains package from 4.0.4, 5 to 4.0.4, 5, 6 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2023-03-01-00-11-30-901-04087278372 branch from fa592b3 to 56e0804 Compare March 1, 2023 00:11
@yebai
Copy link
Member

yebai commented Mar 1, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 1, 2023

👎 Rejected by too few approved reviews

@yebai
Copy link
Member

yebai commented Mar 1, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 1, 2023
… existing compat) (#467)

This pull request changes the compat entry for the `MCMCChains` package from `4.0.4, 5` to `4.0.4, 5, 6` for package test.
This keeps the compat entries for earlier versions.



Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4307627847

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.427%

Totals Coverage Status
Change from base Build 4137356954: 0.0%
Covered Lines: 1819
Relevant Lines: 2444

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8532375) 74.42% compared to head (4a3495a) 74.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files          20       20           
  Lines        2444     2444           
=======================================
  Hits         1819     1819           
  Misses        625      625           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bors
Copy link
Contributor

bors bot commented Mar 1, 2023

@bors bors bot changed the title CompatHelper: bump compat for MCMCChains to 6 for package test, (keep existing compat) [Merged by Bors] - CompatHelper: bump compat for MCMCChains to 6 for package test, (keep existing compat) Mar 1, 2023
@bors bors bot closed this Mar 1, 2023
@bors bors bot deleted the compathelper/new_version/2023-03-01-00-11-30-901-04087278372 branch March 1, 2023 20:40
yebai added a commit that referenced this pull request Mar 2, 2023
…eep existing compat) (#469)

* Fixed a typo in tutorial (#451)

* CompatHelper: bump compat for Turing to 0.24 for package turing, (keep existing compat) (#450)

This pull request changes the compat entry for the `Turing` package from `0.21` to `0.21, 0.24` for package turing.
This keeps the compat entries for earlier versions.



Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Some minor utility improvements (#452)

This PR does the following:
- Moves the `varname_leaves` from `TestUtils` to main module.
  - It can be very useful in Turing.jl for constructing `Chains` and the like, so I think it's a good idea to make it part of the main module rather than keeping it "hidden" there.
- Makes the default `varinfo` in the constructor of `LogDensityFunction` be `model.context` rather than a new `DynamicPPL.DefaultContext`.
  - The `context` pass to `evaluate!!` will override the leaf-context in `model.context`, and so the current default constructor always uses `DefaultContext` as the leaf-context, even if the `Model` has been `contextualize`d with some other leaf-context, e.g. `PriorContext`. This PR fixes this issue.

* Always run CI  (#453)

I find the current `bors` workflow a bit tedious. Most of the time, I summon `bors` to see the CI results (see e.g. #438). Given that most `CI` tests are quick (< 10mins), we can always run them by default. 

The most time-consuming `IntegrationTests` is still run by `bors` to avoid excessive CI runs.

* Compat with new Bijectors.jl (#454)

This PR makes DPPL compatible with the changes to come in TuringLang/Bijectors.jl#214.

Tests are passing locally.

Closes #455 Closes #456

* Another Bijectors.jl compat bound bump (#457)

* CompatHelper: bump compat for MCMCChains to 6 for package test, (keep existing compat) (#467)

This pull request changes the compat entry for the `MCMCChains` package from `4.0.4, 5` to `4.0.4, 5, 6` for package test.
This keeps the compat entries for earlier versions.



Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* CompatHelper: bump compat for AbstractPPL to 0.6 for package test, (keep existing compat)

---------

Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Co-authored-by: github-actions[bot] <compathelper_noreply@julialang.org>
Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants