Skip to content

add support for hasconverged + conditional loading pkgs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 3, 2023
Merged

add support for hasconverged + conditional loading pkgs #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4f591af
add support for hasconverged
zuhengxu Jul 11, 2023
4e31807
fix test error
zuhengxu Jul 11, 2023
99ac0c1
rm example/Manifest.toml
zuhengxu Jul 11, 2023
e4f5efa
minor bug fix for trainig loop
zuhengxu Jul 11, 2023
b345e78
test new stopping criterion
zuhengxu Jul 11, 2023
f10512f
test convergent condition/ rm unready examples
zuhengxu Jul 11, 2023
b93dbe8
Merge branch 'TuringLang:main' into hasconverge
zuhengxu Jul 11, 2023
1c1c88a
rm julia test from CI
zuhengxu Jul 11, 2023
5d2844f
Revert "rm julia test from CI"
zuhengxu Jul 11, 2023
3fdcb0e
make autodiff pkgs as extension + require for bwd compat
zuhengxu Jul 12, 2023
ddad59e
debugging Ext
zuhengxu Jul 12, 2023
ef60ee1
keep debugging
zuhengxu Jul 13, 2023
5a5deb0
Fix AD package extension loading issues
sunxd3 Jul 13, 2023
25d4211
Applying @devmotion's comment
sunxd3 Jul 13, 2023
df5eddd
patch last commit
sunxd3 Jul 13, 2023
d44143b
patch for julia 1.6
sunxd3 Jul 13, 2023
b03e922
loading dep pkgs from main pkg instead of functions for explicitness
zuhengxu Jul 13, 2023
e9acf70
fixing test err
zuhengxu Jul 13, 2023
c6bf68b
rm unready examples
zuhengxu Jul 13, 2023
701c5b5
remove @info when loading zygote ext
zuhengxu Aug 3, 2023
2d05722
directly push stats into [] in training loop
zuhengxu Aug 3, 2023
9412027
fix test error
zuhengxu Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,29 @@ Bijectors = "76274a88-744f-5084-9051-94815aaf08c4"
DiffResults = "163ba53b-c6d8-5494-b064-1a9d43ac40c5"
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9"
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Optimisers = "3bd65402-5787-11e9-1adc-39752487f4e2"
ProgressMeter = "92933f4c-e287-5a05-a399-4b506db050ca"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
Requires = "ae029012-a4dd-5104-9daa-d747884805df"
StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91"

[weakdeps]
Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9"
Comment on lines +15 to +19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems compat entries for Enzyme and Requires are missing - I think this has to be fixed before tagging a release (packages with missing compat entries can't be added to the general registry IIRC).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Yeah, I always forget adding compat entries for denpencies. Will include those in next PR (should be merged soon).

ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"

[extensions]
NormalizingFlowsEnzymeExt = "Enzyme"
NormalizingFlowsForwardDiffExt = "ForwardDiff"
NormalizingFlowsReverseDiffExt = "ReverseDiff"
NormalizingFlowsZygoteExt = "Zygote"

[extras]
Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9"
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"

[compat]
Expand All @@ -30,4 +45,3 @@ ReverseDiff = "1.14"
StatsBase = "0.33, 0.34"
Zygote = "0.6"
julia = "1.6"

Loading