-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] DynamicHMC support #549
Conversation
I think passing in number of adaptions is probably enough here. We can leave target accept rate as default. |
This PR is almost finished. One question on testing: for functionality which using Requires.jl, what's the best way to put them in our test system? Do we actually want to manually set up travis to install, say, DynamicHMC.jl related packages and do the tests? |
Perhaps we can install them from |
I wonder if the new environment thing can be used? If not we will do that manually. |
Let’s do this manually for now. |
I’m using runtest.jl to install packages only required for tests in MCMCChain. Adding Pkg.add to Travis didn’t work for me. |
Hmm, strange. Any idea why? |
55bb83e
to
4f02173
Compare
Seems the issue is not on the Turing side -- something weird is going on with |
The proper way to do this is using a |
Can you refer to unregistered packages in the REQUIRE file? |
If the unregistered package has a |
Cool, thanks @mohamed82008! |
Seems related to the recent automatic capping https://discourse.julialang.org/t/package-compatibility-caps/15301. I think |
Closing and reopening again to trigger CI. |
The vec_assume_mat.jl test fails (https://travis-ci.org/TuringLang/Turing.jl/jobs/431989506#L897-L949) on both the Linux Travis and AppVeyor (but is OK for macOS Travis). |
TODOs
figure out how to pass target accept rate and number of adaptations to DynamicHMCSummary
The way I'm current supporting DynamicHMC is through a keyword argument called
implementation
insample
, e.g.sample(model_func, DynamicNUTS(...))
. See the test file for a complete example.