Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alerting): Resolve GoogleChat bad payload issue #363

Merged
merged 5 commits into from
Nov 11, 2022
Merged

fix(alerting): Resolve GoogleChat bad payload issue #363

merged 5 commits into from
Nov 11, 2022

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Nov 9, 2022

Summary

Should fix #362

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@TwiN
Copy link
Owner Author

TwiN commented Nov 9, 2022 •
edited
Loading

Publishing image with experimental tag for testing purposes: https://github.com/TwiN/gatus/actions/runs/3424685527

@TwiN TwiN mentioned this pull request Nov 9, 2022
Closed
@TwiN TwiN changed the title fix(alerting): Resolve GoogleChat issue with bad payload when condition has " in it fix(alerting): Resolve GoogleChat bad payload issue Nov 11, 2022
@TwiN TwiN added bug Something isn't working area/alerting Related to alerting labels Nov 11, 2022
@TwiN TwiN merged commit b801cc5 into master Nov 11, 2022
@TwiN TwiN deleted the fix/googlechat branch November 11, 2022 03:12
@TwiN
Copy link
Owner Author

TwiN commented Nov 12, 2022

This didn't fix all issues with the provider.
See #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/alerting Related to alerting bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GoogleChat alerts are blank under certain conditions for ICMP endpoints
1 participant
@TwiN