Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerting): Resolve issue with blank GoogleChat messages #364

Merged
merged 8 commits into from
Nov 23, 2022

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Nov 11, 2022

Summary

Fixes #362

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@TwiN TwiN added bug Something isn't working area/alerting Related to alerting labels Nov 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Base: 81.85% // Head: 81.93% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (df47ccf) compared to base (4f569b7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   81.85%   81.93%   +0.07%     
==========================================
  Files          54       54              
  Lines        4056     4057       +1     
==========================================
+ Hits         3320     3324       +4     
+ Misses        578      576       -2     
+ Partials      158      157       -1     
Impacted Files Coverage Δ
alerting/provider/googlechat/googlechat.go 94.05% <100.00%> (+0.05%) ⬆️
config/maintenance/maintenance.go 100.00% <0.00%> (+3.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TwiN TwiN marked this pull request as ready for review November 23, 2022 01:11
@TwiN TwiN merged commit f8140e0 into master Nov 23, 2022
@TwiN TwiN deleted the fix/googlechat branch November 23, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoogleChat alerts are blank under certain conditions for ICMP endpoints
2 participants