Skip to content

Feature/uri randomizer #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2018
Merged

Feature/uri randomizer #114

merged 3 commits into from
May 16, 2018

Conversation

twenzel
Copy link
Contributor

@twenzel twenzel commented May 14, 2018

  • Add randomizer for Uri
  • Add randomizer for urls (strings)

Fixes #113

@Tynamix
Copy link
Owner

Tynamix commented May 14, 2018

Thank you very much for your contribution <3

Tynamix
Tynamix requested changes May 14, 2018
View reviewed changes
Copy link
Owner

@Tynamix Tynamix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, that we have a randomizer for type uri it is necessary to set it up as default randomizer for type uri. This can be done in the class FillerSetupItem in the method SetDefaultRandomizer - otherwise objectfiller would not use this great plugin by default.

Tynamix.ObjectFiller/Plugins/RandomUri.cs Outdated
/// </summary>
/// <param name="schemeType">Type of the scheme.</param>
/// <param name="domainNames">The possible domain names.</param>
public RandomUri(SchemeType schemeType, IEnumerable<string> domainNames)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params string[] would be perfect

Tynamix.ObjectFiller/Plugins/String/RandomUrl.cs Outdated
/// </summary>
/// <param name="schemeType">Type of the scheme.</param>
/// <param name="domainNames">The possible domain names.</param>
public RandomUrl(SchemeType schemeType, IEnumerable<string> domainNames)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params string[] would be perfect

@twenzel
Use params array instead
1fdfa63 
Set as default randomizer for type Uri
@Tynamix Tynamix merged commit 52e4645 into Tynamix:develop May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tynamix Tynamix Tynamix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twenzel @Tynamix