Skip to content

Conversation

YousefED
Copy link
Collaborator

@YousefED YousefED commented Mar 5, 2023

I think it'd be nicest to keep the unit tests next to the actual files, and limit them to testing functions from that file. Reasoning:

  • Keeping them next to the file makes it clearer you need to add / update a unit test when changing the file itself
  • It's consistent with what we do for TypeCell
  • I think it will help us to keep our code clean and use small functions. Ideally every important function should have a "describe" item, with one or more "it" tests. + of course there can be some "describes" that test multiple methods combined
    not the highest prio either atm

@vercel
Copy link

vercel bot commented Mar 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blocknote ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 5, 2023 at 1:29PM (UTC)

@YousefED YousefED requested a review from matthewlipski March 5, 2023 13:28
@YousefED YousefED merged commit e310448 into main Mar 6, 2023
fogle pushed a commit to fogle/BlockNote that referenced this pull request May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant