Skip to content

Conversation

YousefED
Copy link
Collaborator

@YousefED YousefED commented Mar 7, 2023

  • add support for dragging / dropping next to the editor
  • fixes drag previews for nested items

drag

@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blocknote ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 11:30AM (UTC)

Copy link
Collaborator

@matthewlipski matthewlipski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, great that you cleaned up the event handlers too. Since we don't call preventDefault I guess that we get 2 drop and drag over events being triggered? Don't think it's an issue either way but might be something to remember for the future.

@YousefED
Copy link
Collaborator Author

YousefED commented Mar 7, 2023

I think the prosemirror handlers will call preventDefault. Not 100% sure, but good to keep in mind indeed

@YousefED YousefED merged commit 79b6261 into main Mar 7, 2023
fogle pushed a commit to fogle/BlockNote that referenced this pull request May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants