Skip to content

fix: externalize unified plugins by adding them to package.json #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

YousefED
Copy link
Collaborator

I think this might have been breaking the sandpack examples. in vite.config.ts, we have the following setting:

// make sure to externalize deps that shouldn't be bundled
      // into your library
      external: (source: string) => {
        if (deps.includes(source)) {
          return true;
        }
        return source.startsWith("prosemirror-");
      },

We imported several packages that were not explicitly in "dependencies". this then caused the remark plugins to end up in our blocknote.umd.js built file. My guess is this broke the examples

@YousefED YousefED requested a review from matthewlipski March 14, 2023 20:23
@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blocknote ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 8:39PM (UTC)
blocknote-website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 8:39PM (UTC)

@YousefED
Copy link
Collaborator Author

confirmed to fix the dependency errors

@YousefED YousefED merged commit 21e082b into main Mar 14, 2023
fogle pushed a commit to fogle/BlockNote that referenced this pull request May 20, 2023
…CellOS#128)

* fix: externalize unified plugins by adding them correctly to package json

* v0.4.6-alpha.0

* fix defaults / rollup interop

* v0.4.6-alpha.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant