Skip to content

fix: slashmenu dropdown positioning on edge of page #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

tensor-tian
Copy link
Contributor

@tensor-tian tensor-tian commented Apr 14, 2023

martine menu dropdown position style is set to "absolute".
The tippy container's ( the parent of dropdown menu ) computed width and height are 0.
This makes popper overflow not work when change the type of last several blocks.

before fix, popper's overflow detection not work:
Screenshot 2023-04-14 at 18 17 10

after fix, popper's default flip behavior work:
Screenshot 2023-04-14 at 18 22 11

@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocknote-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 10:19am

Copy link
Collaborator

@matthewlipski matthewlipski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@YousefED YousefED changed the title reset menu dropdown postion to static fix: slashmenu dropdown positioning on edge of page Apr 18, 2023
@YousefED
Copy link
Collaborator

Thanks @tensor-tian! We'll make this part of the next release!

@YousefED YousefED merged commit c9513cd into TypeCellOS:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants