Skip to content

fix: Code block language select value not updating properly #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

fix: Code block language select value not updating properly #2050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions packages/core/src/blocks/Code/block.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,18 +117,6 @@ export const createCodeBlockSpec = createBlockSpec(
if (options.supportedLanguages) {
const select = document.createElement("select");

const handleLanguageChange = (event: Event) => {
const language = (event.target as HTMLSelectElement).value;

editor.updateBlock(block.id, { props: { language } });
};
select.addEventListener("change", handleLanguageChange);

const selectWrapper = document.createElement("div");
selectWrapper.contentEditable = "false";
select.value =
block.props.language || options.defaultLanguage || "text";

Object.entries(options.supportedLanguages ?? {}).forEach(
([id, { name }]) => {
const option = document.createElement("option");
Expand All @@ -138,11 +126,23 @@ export const createCodeBlockSpec = createBlockSpec(
select.appendChild(option);
},
);
selectWrapper.appendChild(select);
wrapper.appendChild(selectWrapper);
select.value =
block.props.language || options.defaultLanguage || "text";

const handleLanguageChange = (event: Event) => {
const language = (event.target as HTMLSelectElement).value;

editor.updateBlock(block.id, { props: { language } });
};
select.addEventListener("change", handleLanguageChange);
removeSelectChangeListener = () =>
select.removeEventListener("change", handleLanguageChange);

const selectWrapper = document.createElement("div");
selectWrapper.contentEditable = "false";

selectWrapper.appendChild(select);
wrapper.appendChild(selectWrapper);
}
wrapper.appendChild(pre);

Expand Down
Loading