Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address React Warning when clicking DragHandleMenuItem #210

Merged
merged 1 commit into from
May 25, 2023

Conversation

fogle
Copy link
Contributor

@fogle fogle commented May 25, 2023

Filter out closeMenu from the props so React stops warning about it.

To generate the warning without this change, simply click on the drag handle menu with your dev console open.

Screenshot 2023-05-24 at 8 26 20 PM

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 0:35am
blocknote-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 0:35am

@YousefED YousefED changed the title Address React Warning fix: Address React Warning when clicking DragHandleMenuItem May 25, 2023
Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@YousefED YousefED merged commit a29718f into TypeCellOS:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants