feat: Unit tests for block type guards #2103
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds unit tests for
editorHasBlockWithType
.The code for
editorHasBlockWithType
has also been changed slightly - when checking for a block with a givenpropSchema
andvalues
, thevalues
can be an unordered subset of the ones in the schema. Previously, the 2 arrays had to be identical in order for the type guard to returntrue
.Rationale
Needed for #2096 and useful in general.
Changes
See above.
Impact
N/A
Testing
See above.
Screenshots/Video
N/A
Checklist
Additional Notes