fix: Custom blocks without inline content

[matthewlipski]

A recent change has broken custom blocks which don't contain inline content. This is because we added edge case handling in getBlockInfoFromPos, for situations where the selection is outside of any blocks. However, nodeToBlock was unnecessarily and incorrectly calling getBlockInfoFromPos with the blockContainer node instead of the doc, and was causing errors when inserting custom blocks without inline content.

Closes #300

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
blocknote-website	✅ Ready (Inspect)	Visit Preview	Aug 18, 2023 10:30pm

[YousefED]

Why was the call incorrect?

Nice that it's fixed. I do think we can improve this by making getBlockInfoFromPos and nodeToBlock call a method blockContainerNodeToBlockInfo or something? That would remove some duplicate code right?

[matthewlipski]

Why was the call incorrect?

Nice that it's fixed. I do think we can improve this by making getBlockInfoFromPos and nodeToBlock call a method blockContainerNodeToBlockInfo or something? That would remove some duplicate code right?

Well thing is that the main point of getBlockInfoFromPos is finding the nearest blockContainer node. Getting stuff like child count, depth, etc is pretty trivial after that. So it doesn't really make sense to call it if you already have the blockContainer node imo. Your suggestion makes sense though, just having a getBlockInfo function which takes a blockContainer node instead of a position.