New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Slash Command Android Chrome Issue #437 #443
fix: Slash Command Android Chrome Issue #437 #443
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Kashifwahaj is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
Nice find! Do you think you could just extract the code into a separate function? Since seems like it's basically the same as for the |
…bug-TypeCellOS#437-slash-not-working-on-android-chrom
Thanks for the suggestion, I updated and pushed the code. |
@matthewlipski is there anything else you suggest for this PR ? |
…bug-TypeCellOS#437-slash-not-working-on-android-chrom
@matthewlipski @YousefED Please can we proceed with this PR, let me know if any improvement or changes required |
@matthewlipski did you check if we still need both handlers? |
Hi,
I investigated the issue, The
handleKeyDown
event is not returning properly updated objects on the Android Chrome browser, so I think we need to use thehandleTextInput
method to fix this.Thanks