Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Slash Command Android Chrome Issue #437 #443

Conversation

Kashifwahaj
Copy link
Contributor

Hi,
I investigated the issue, The handleKeyDown event is not returning properly updated objects on the Android Chrome browser, so I think we need to use the handleTextInput method to fix this.

Thanks

Copy link

vercel bot commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Apr 2, 2024 5:16pm
blocknote-website ✅ Ready (Inspect) Visit Preview Apr 2, 2024 5:16pm

Copy link

vercel bot commented Dec 2, 2023

@Kashifwahaj is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@matthewlipski
Copy link
Collaborator

Nice find! Do you think you could just extract the code into a separate function? Since seems like it's basically the same as for the handleKeyDown handler, so would be great if we could use the same code for both

@Kashifwahaj
Copy link
Contributor Author

Nice find! Do you think you could just extract the code into a separate function? Since seems like it's basically the same as for the handleKeyDown handler, so would be great if we could use the same code for both

Thanks for the suggestion, I updated and pushed the code.

@Kashifwahaj Kashifwahaj changed the title #437 Slash Command Android Chrome Issue fixed fix: Slash Command Android Chrome Issue #437 Dec 6, 2023
@Kashifwahaj
Copy link
Contributor Author

@matthewlipski is there anything else you suggest for this PR ?

@Kashifwahaj
Copy link
Contributor Author

@matthewlipski ?

@Kashifwahaj
Copy link
Contributor Author

@matthewlipski @YousefED Please can we proceed with this PR, let me know if any improvement or changes required

@matthewlipski matthewlipski merged commit de8bea8 into TypeCellOS:main Apr 2, 2024
4 checks passed
@YousefED
Copy link
Collaborator

YousefED commented Apr 3, 2024

@matthewlipski did you check if we still need both handlers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants