feat: Separate image, hyperlink, & table components for export #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Nice. Left some comments, also, I think we wanted to streamline more inside the shared/Toolbar directory. iirc this was related to ToolbarDropdown* and ToolbarInputDropdown* etc. right? (I think at least the naming isn't clear, but I think you wanted to combine more code)
packages/react/src/components/HyperlinkToolbar/mantine/DefaultButtons/EditLinkButton.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/ImageToolbar/mantine/ImageToolbar.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/ImageToolbar/mantine/ImageToolbar.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/ImageToolbar/mantine/ImageToolbarPanel.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/TableHandles/mantine/TableHandle.tsx
Outdated
Show resolved
Hide resolved
YousefED
reviewed
Mar 14, 2024
packages/react/src/components/FormattingToolbar/mantine/DefaultButtons/CreateLinkButton.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/ImageToolbar/ImagePanelController.tsx
Outdated
Show resolved
Hide resolved
* Cleaned up component code * Renamed "Link" in components to "Hyperlink" * Implemented PR feedback * alternative solution for toolbar fadeout (#645) * chore: Playwright update (#640) * Updated playwright * Small fix * dont upgrade tiptap etc * fix pw install? --------- Co-authored-by: yousefed <yousefdardiry@gmail.com> * fix `setEditable` called when not necessary (#635) * Added temp fix for shortcuts and input rules in tables (#561) --------- Co-authored-by: Yousef <yousefdardiry@gmail.com>
YousefED
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the components for the hyperlink toolbar, image toolbar, and table handles so that they can be exported and used by consumers to customize those UI elements. Closes #608
It also cleans up code for children of the Toolbar component, as well as some other small/misc cleanups for components. See #637 for that.