Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialize React content with existing React tree #641

Merged
merged 3 commits into from Mar 14, 2024

Conversation

YousefED
Copy link
Collaborator

@YousefED YousefED commented Mar 13, 2024

closes #623
closes #592

Todo:

  • Add unit test, probably to htmlConversion.test.ts

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 13, 2024 6:12pm
blocknote-website ✅ Ready (Inspect) Visit Preview Mar 13, 2024 6:12pm

@YousefED YousefED changed the title serialize React content with existing React tree fix: serialize React content with existing React tree Mar 14, 2024
Copy link
Collaborator Author

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewlipski ! Ready to be merged imo

@matthewlipski matthewlipski merged commit 2b01f5e into main Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom block is not draggable Copying to clipboard of react custom blocks that use context
2 participants