Skip to content

fix: PDF block example styling #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix: PDF block example styling #785

merged 2 commits into from
Jun 4, 2024

Conversation

matthewlipski
Copy link
Collaborator

Closes #767

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 4, 2024 5:53pm
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 4, 2024 5:53pm

YousefED
YousefED reviewed Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Should we fix this only for the PDF example, or is this styling that we should add to the overall style file?

@matthewlipski
Copy link
Collaborator Author

Nice. Should we fix this only for the PDF example, or is this styling that we should add to the overall style file?

Whoops, nope this styling is definitely PDF specific, fixed the CSS scoping to reflect that

@matthewlipski matthewlipski merged commit bb1bdce into main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YousefED YousefED YousefED left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pdf style [Bug]
2 participants
@matthewlipski @YousefED