-
-
Notifications
You must be signed in to change notification settings - Fork 581
fix(ui): missing margin in checklist while in RTL #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@zaaakher is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
@YousefED Any thoughts on this part? I couldn't quickly find any resources online to support my suggestion about the standard space between checkboxes and their title so I asked chatGPT 👇 |
I agree a smaller margin looks better and is more inline with Notion. Looping in @matthewlipski for this as he made the original check box |
Ok I just decreased it to |
Agreed, does look closer to Notion so I changed the other list item blocks to use the same margin also |
This tiny PR fixes a missing space next to the checkbox in checklists while in an RTL user interface.
Before
After
Althought on a side note,
1.2em
feels a little too large of a space between the checkbox and the text. I suggest0.5em
.1.2 em
0.5 em
If you agree
0.5em
is better spacing, let me know and I will add a commit changing it from 1.2 to 0.5