Skip to content

fix(ui): missing margin in checklist while in RTL #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

zaaakher
Copy link
Contributor

@zaaakher zaaakher commented Jun 7, 2024

This tiny PR fixes a missing space next to the checkbox in checklists while in an RTL user interface.

Before

image

After

image


Althought on a side note, 1.2em feels a little too large of a space between the checkbox and the text. I suggest 0.5em.

1.2 em

image

0.5 em

image

If you agree 0.5em is better spacing, let me know and I will add a commit changing it from 1.2 to 0.5

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 13, 2024 0:52am
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 13, 2024 0:52am

Copy link

vercel bot commented Jun 7, 2024

@zaaakher is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@zaaakher
Copy link
Contributor Author

zaaakher commented Jun 8, 2024

1.2em feels a little too large of a space between the checkbox and the text. I suggest 0.5em.

@YousefED Any thoughts on this part? I couldn't quickly find any resources online to support my suggestion about the standard space between checkboxes and their title so I asked chatGPT 👇

image

@YousefED
Copy link
Collaborator

YousefED commented Jun 8, 2024

I agree a smaller margin looks better and is more inline with Notion. Looping in @matthewlipski for this as he made the original check box

@zaaakher
Copy link
Contributor Author

zaaakher commented Jun 8, 2024

Ok I just decreased it to 0.5em 👍

@matthewlipski
Copy link
Collaborator

I agree a smaller margin looks better and is more inline with Notion. Looping in @matthewlipski for this as he made the original check box

Agreed, does look closer to Notion so I changed the other list item blocks to use the same margin also

@matthewlipski matthewlipski merged commit e17cbc0 into TypeCellOS:main Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants