Skip to content

Conversation

YousefED
Copy link
Collaborator

@YousefED YousefED commented Jul 16, 2024

Should be tested well to make sure built js files don't have breaking changes and that dev experience is still ok

Note: now set emoji-loading as base branch, should probably be set to main after merging emoji-loading

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jul 16, 2024 9:01pm
blocknote-website ✅ Ready (Inspect) Visit Preview Jul 16, 2024 9:01pm

Copy link
Collaborator

@matthewlipski matthewlipski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested built JS files on a NextJS app and didn't cause any issues in both built and dev envs.

@matthewlipski matthewlipski merged commit dd66d0b into fix/emoji-loading Jul 18, 2024
matthewlipski added a commit that referenced this pull request Jul 18, 2024
* improve emoji loading

* use default export for emojiMart for nodejs compat

* upgrade vite and vitest (#939)

* Reverted default `emoji-mart` import

---------

Co-authored-by: matthewlipski <matthewlipski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants