Skip to content

fix: Side menu not actually freezing #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

matthewlipski
Copy link
Collaborator

@matthewlipski matthewlipski commented Jul 17, 2024

Seems like freezeMenu was not actually fully freezing the side menu, as mousemove events were still being handled as normal and dispatching updates when they should be ignored.

Closes #911

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jul 17, 2024 11:25am
blocknote-website ✅ Ready (Inspect) Visit Preview Jul 17, 2024 11:25am

@matthewlipski matthewlipski changed the title Made side menu mousemove event return instantly when menu is frozen fix: Side menu not actually freezing Jul 17, 2024
@matthewlipski matthewlipski merged commit 2064dfc into main Jul 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SideMenu Shadcn major bug
2 participants