outFile option prevents output

[PierreAnctil]

When adding the outFileoption in tsconfig.json, the output is not generated.

See the minimalist attached example:
When the outFile option is removed, the output files are generated (but in several files).
When using tsc in the command line, the output is generated.

Config:
atom 1.5.4
atom-typescript 8.3.0
typescript 1.8.7
Windows 10

test.zip

[basarat]

Reported in the wild as well : http://stackoverflow.com/questions/36024552/atom-tsconfig-not-compiling-when-it-vscode-it-does

[sky0matic]

Seems like we have to change that here :
https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/tsconfig/tsconfig.ts#L317
to reflect compilerOptions.outFile = ... instead.

Doing so fix the compilling with outFile, but the compile time is really slow.

[basarat]

Makes sense. Would also like it if out is moved to outFile https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/tsconfig/tsconfig.ts#L311-L313 and then outFile is used wherever out is used in the codebase currently (projectService.ts and building.ts) 🌹

[sky0matic]

I fixed it, How can I push my branch ?

[basarat]

@iTouchTheSky hopefully you pressed the fork button on top and then you did the edits to your local branch. If so just do git add . git commit -m "your message" and then git push. Now if you go to your fork on github (it should show your commits as the last ones there) you should see a "Create Pull Request" button.

Alternatively you can edit the file here online (edit button on top of each file). Github will automatically create a fork and add your commits and allow you to create a PR (pull request).

More : https://help.github.com/articles/using-pull-requests/ 🌹

[basarat]

Please https://github.com/TypeStrong/atom-typescript/releases/tag/v8.3.1 a go 🌹

[PierreAnctil]

I just tried 8.3.1 and the issue is indeed resolved
Thanks a lot @iTouchTheSky and @basarat

[sky0matic]

No problem I needed it for my workspace too so I figured why not fix it instead of waiting on someone to fix it :)