feat(SP-1744): update to gitleaks v8 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @davidsalvador-tf, thank you about implementing this! In step 3 you mentioned Also do you have a plan on how to create PR to all repos already? (we have this, might be helpful) |
|
You're right @alexkravch! I just fixed the step description. About the PRs, yep I was planning on using that tool as I need to update around 50 repos. |
alexkravch
approved these changes
Jun 30, 2022
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tool
gitleaksused in the secrets detection check to its latest major version.gitleaksAPI and exception file for every repo (.gitleaks.toml) is broken with this new version. So, the migration plan I have in mind is the following:ci-standard-checks@v1-betaci-standard-checks@v1-beta.gitleaks.tomlfile and useci-standard-checks@v1. The PR will update.gitleaks.tomlto make it compatible withgitleaksversion 8 and also make the repos useci-standard-checks@v1-betaci-standard-checks@v1-betatoci-standard-checks@v1and submit PRs to the same repos to make them useci-standard-checks@v1instead ofci-standard-checks@v1-betaMaybe there's a better migration plan, let me know what you think. Thanks!