Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEMO] Loads of suggestions #109

Closed

Conversation

Jay-o-Way
Copy link
Contributor

@Jay-o-Way Jay-o-Way commented Mar 20, 2024

Hi,

I took the liberty to make some changes, hoping to help. Of course, this is how "I" would do things. It's your project and you are free to accept everything you want. Also, it might not be perfect right now, please do double-check.

Comments / details

  • TO-DO: check why IsEnabled="{Binding UseCustomRule.IsChecked}" doesn't work ⚠️
  • General tidy-up of XAML and layouts, incl. window sizes
  • Use a CheckBox for optional use of custom rule; merged the CS code together and use IF statement
  • Use an InfoBar to display the test result
  • Feel free to ask for more info

Screenshots

image
image
image

@Jay-o-Way Jay-o-Way marked this pull request as ready for review March 20, 2024 18:26
@U-C-S
Copy link
Owner

U-C-S commented Mar 21, 2024

Woah, Thanks for this.... I can use your PR as starting phase to work on next set of stuff.

Of course, this is how "I" would do things. It's your project and you are free to accept everything you want

😅 yeh, I am kind of opinionated about some stuff, but I do like some of the things here, which I will salvage out of this.

@U-C-S U-C-S changed the base branch from main to feat/browser-settings March 21, 2024 16:41
@U-C-S
Copy link
Owner

U-C-S commented Apr 18, 2024

Wouldn't this PR create conflicts with #114 once either of these are merged ??

@Jay-o-Way
Copy link
Contributor Author

Oh yes. Definitely. This is a PR I made in a rather short time, mostly to demo ideas, as I would approach. You also have your personal ideas for the "re-write" milestone. In any case, it's always better to be more targeted with PRs.

@Jay-o-Way Jay-o-Way changed the title Loads of suggestions [DEMO] Loads of suggestions Apr 18, 2024
@Jay-o-Way Jay-o-Way marked this pull request as draft May 21, 2024 22:03
@Jay-o-Way Jay-o-Way closed this Jul 4, 2024
@Jay-o-Way Jay-o-Way deleted the load-of-suggestions branch July 5, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants