Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes from zubaxdoc.cls to uavcandoc.cls #85

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Conversation

clyde-johnston
Copy link

This PR fixes issue #35.

@pavel-kirienko
Copy link
Member

The tables in the document have to be updated because now with the new default left skip behavior some of them should be amended with [wide] (those that are wide enough).

The doc should also be skimmed to look for formatting issues introduced by the switch to newer LaTeX.

I think we should also release a new version of the texer container but this is obviously out of the scope of this PR.

@clyde-johnston
Copy link
Author

I think we should also release a new version of the texer container but this is obviously out of the scope of this PR.

Opened issue #9 in UAVCAN/docker_toolchains for this.

@clyde-johnston
Copy link
Author

The tables in the document have to be updated because now with the new default left skip behavior some of them should be amended with [wide] (those that are wide enough).

The doc should also be skimmed to look for formatting issues introduced by the switch to newer LaTeX.

This should be directed to the typographer. My quick scan of the document did not find any issues although tables 4.2 and 4.3 might be candidates for the [wide] option.

Also, some tables seem to have been included as images and thus to do not conform to the standard alignments. It might be better to change these to LaTeX tables.

@pavel-kirienko
Copy link
Member

Okay. I looked through the doc and I think we need [wide] on tables 3.12, 3.14, 4.2, 4.3, 7.1, 7.5, 7.6, plus all tables generated by render_dsdl.py (they are raw tabus so maybe they don't need fixing at all). Could you please update this PR accordingly?

@clyde-johnston
Copy link
Author

Could you please update this PR accordingly?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants