Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow helix index changing in batch #36

Closed
dave-doty opened this issue Dec 14, 2019 · 2 comments
Closed

allow helix index changing in batch #36

dave-doty opened this issue Dec 14, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request high priority Something cruicial to get working soon.

Comments

@dave-doty
Copy link
Member

dave-doty commented Dec 14, 2019

Allow both the index of each helix in the list of all helices to be altered, and also the view order specified in DNADesign.helices_view_order.

Furthermore, now that helices are not constrained to be consecutive (#172), allow to change helix indices to be any integers.

@dave-doty dave-doty added the enhancement New feature or request label Dec 14, 2019
@dave-doty dave-doty added the high priority Something cruicial to get working soon. label Feb 2, 2020
@dave-doty dave-doty changed the title allow helix index reordering allow helix index reordering and changing Feb 2, 2020
dave-doty added a commit that referenced this issue Jul 22, 2020
…e changed one at a time, and not with a recalculation of view order until #407 is addressed
@dave-doty
Copy link
Member Author

dave-doty commented Dec 13, 2020

This was partially addressed by commit 2eab946, which allows changing the index of a helix one at a time. I'm leaving the issue open to allow a faster way to re-index all helices at once. Currently they can only be changed one at a time. Swapping two is particularly annoying since one needs to assign one of them a temporary index not belonging to any helix to avoid collision.

There's also currently no way in the web interface to leave indices alone but change the helices_view_order property of a HelixGroup. Update: This can now be done by adjusting the current HelixGroup:

image

@dave-doty dave-doty changed the title allow helix index reordering and changing allow helix index changing in batch May 15, 2021
@dave-doty
Copy link
Member Author

Unlike helices_view_order, which has a meaning that does not depend on the old helices_view_order, re-numbering helices requires that you know the old helix numbers when assigning new ones. So entering it the same way as helices_view_order would be harder to use, since, after erasing the old list of indices, one would have to remember what order they appeared in for the new indices to make sense.

So, it seems best to implement this in a more structured way, where the hold indices are displayed read-only, with each of them next to a text field where the new index can be chosen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Something cruicial to get working soon.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants