Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #500; freeze versions in all GitHub actions #506

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Fixes #500; freeze versions in all GitHub actions #506

merged 4 commits into from
Nov 9, 2020

Conversation

UnHumbleBen
Copy link
Collaborator

No description provided.

@UnHumbleBen
Copy link
Collaborator Author

UnHumbleBen commented Nov 9, 2020 •
edited
Loading

I am confused on why the CI is stuck when trying to compile the UT. Locally, the UT runs fine with dart version 2.9.3.

@dave-doty
Copy link
Member

I am confused on why the CI is stuck when trying to compile the UT. Locally, the UT runs fine with dart version 2.9.3.

Also the unit tests seem to be stuck (for 2 hours):

image

@UnHumbleBen
Copy link
Collaborator Author

Also the unit tests seem to be stuck (for 2 hours):

Yes. This is what I meant by UT. I'm not sure what the cause could be. I am unable to reproduce this hanging issue on my local machine.

@UnHumbleBen
Copy link
Collaborator Author

Update: I am able to reproduce the hanging issue after running pub upgrade. Perhaps I was still using packages I installed with dart version 2.10.

@UnHumbleBen
Copy link
Collaborator Author

Alright looks like I finally have the correct version set. Just needed to upgrade build_runner. Awaiting your approval @dave-doty

dave-doty
dave-doty approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@dave-doty dave-doty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix the GitHub pages deployment issue?

@UnHumbleBen
Copy link
Collaborator Author

Yup, it fixed in in my fork. Now to put it to the real test. Merging.

@UnHumbleBen UnHumbleBen merged commit 3f5c704 into dev Nov 9, 2020
@UnHumbleBen UnHumbleBen deleted the dev-issue-500 branch November 22, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-doty dave-doty dave-doty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UnHumbleBen @dave-doty