Fixes #490; store old versions of scadnano at version-specific URLs #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-doty
approved these changes
Nov 12, 2020
I see a 404 error on the second link. |
|
Fix linked in my comment: https://github.com/UnHumbleBen/scadnano/actions/runs/358816601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in Fork: https://unhumbleben.github.io/scadnano/v0.11.3/
Here is example of when version number cannot be parsed: https://github.com/UnHumbleBen/scadnano/actions/runs/358816601
Root deployment still runs, but version url gets skipped and a warning message is fired so that we know we need to fix the version string.